-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiselect design update #296
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishichawda
added
design-update 🎨
Design Update for components
Priority: High
Status: Review Needed 🔎
Type: Bug 🐛
labels
Dec 31, 2018
kaushiknishchay
suggested changes
Dec 31, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Change the List Item Hover and selected Values color, Currently both are same.
Selected Values Chip:
- add padding on the left of close icon
@kaushiknishchay Updated the hover styles and chip icon. Also added animation on selecting an item. |
kaushiknishchay
approved these changes
Dec 31, 2018
KRRISH96
approved these changes
Jan 1, 2019
rishichawda
added a commit
to rishichawda/react-lite-ui
that referenced
this pull request
Jan 1, 2019
…rahma#296) * fix(multiselect): update option height and icon Codebrahma#287 * fix(multiselect): fix chip design and update icon * fix(multiselect): bug fix on selecting items * refactor(multiselect): remove dead code * fix(multiselect): update multiselect design * fix(multiselect): update selected chip animation
🎉 This PR is included in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status :
Ready
Description :
Minor design updates.
Bug fix.
Related Issues :
#287
Todos